-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show upload menu in folders' emptycontent #44272
Conversation
17ac04c
to
45f02fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and seems to work. Really nice UX improvement! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM nice UX!
@marcoambrosini can you please adjust your commit message to comply with conventional commits? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error message does not mean the folder truly exists
So what would be the best way to check that the folder exists @skjnldsv |
There are many factors you need to check to show an UploadPicker
Additional data:What you are editing is shared between ALL views, the deleted files, the tags, the shares, favorites.... etc. We need to keep the |
@marcoambrosini do you still want to have this in beta 6? If so, the last call for that is happening now, otherwise we have to move it to 30. |
@jancborchardt we're far into features freeze (3 weeks) and Rc1 is this week |
a47732f
to
6ba706a
Compare
@skjnldsv @marcoambrosini I pushed a commit to bring back the back button if upload is not possible. |
6ba706a
to
bd4a107
Compare
/compile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
I can't figure out what's wrong with the failures |
Signed-off-by: Marco <[email protected]>
…an not upload Signed-off-by: Ferdinand Thiessen <[email protected]>
65b1156
to
1463592
Compare
Thanks @susnux ! |
What was it @susnux ? |
Just flaky and needed to be restarted |
Before
After